Skip to content

RFC: Bounds on trait objects should be separated with + #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions active/0000-trait-bounds-with-plus.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
- Start Date: 2014-05-22
- RFC PR #: (leave this empty)
- Rust Issue #: (leave this empty)

# Summary

Bounds on trait objects should be separated with `+`.

# Motivation

With DST there is an ambiguity between the following two forms:

trait X {
fn f(foo: b);
}


and

trait X {
fn f(Trait: Share);
}

See Rust issue #12778 for details.

Also, since kinds are now just built-in traits, it makes sense to treat a bounded trait object as just a combination of traits. This could be extended in the future to allow objects consisting of arbitrary trait combinations.

# Detailed design

Instead of `:` in trait bounds for first-class traits (e.g. `&Trait:Share + Send`), we use `+` (e.g. `&Trait + Share + Send`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ would be commutative, right? so &Share + Send + Trait would also work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually. In the first implementation it will not.


`+` will not be permitted in `as` without parentheses. This will be done via a special *restriction* in the type grammar: the special `TYPE` production following `as` will be the same as the regular `TYPE` production, with the exception that it does not accept `+` as a binary operator.

# Drawbacks

* It may be that `+` is ugly.

* Adding a restriction complicates the type grammar more than I would prefer, but the community backlash against the previous proposal was overwhelming.

# Alternatives

The impact of not doing this is that the inconsistencies and ambiguities above remain.

# Unresolved questions

Where does the `'static` bound fit into all this?