repr(ordered_fields)

text/3845-repr-ordered-fields.md

@@ -0,0 +1,318 @@
+- Feature Name: `repr_ordered_fields`
+- Start Date: 2025-08-05
+- RFC PR: [rust-lang/rfcs#3845](https://github.com/rust-lang/rfcs/pull/3845)
+- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)
+
+# Summary
+[summary]: #summary
+
+Introduce a new `repr` (let's call it `repr(ordered_fields)`, but that can be bikeshedded if this RFC is accepted) that can be applied to `struct`, `enum`, and `union` types, which guarantees a simple and predictable layout. Then provide an initial migration plan to switch users from `repr(C)` to `repr(ordered_fields)`.
+
+# Motivation
+[motivation]: #motivation
+
+Currently `repr(C)` serves two roles
+1. Provide a consistent, cross-platform, predictable layout for a given type
+2. Match the target C compiler's struct/union layout algorithm and ABI
+
+But in some cases, these two cases are in tension due to platform weirdness (even on major platforms like Windows MSVC)
+* https://github.com/rust-lang/unsafe-code-guidelines/issues/521
+* https://github.com/rust-lang/rust/issues/81996
+
+Providing any fix for case 2 would subtly break any users of case 1, which makes this difficult to fix within a single edition. 
+
+As an example of this tension: on Windows MSVC, `repr(C)` doesn't always match what MSVC does for  ZST structs (see this [issue](https://github.com/rust-lang/rust/issues/81996) for more details)
+
+```rust
+// should have size 8, but has size 0
+#[repr(C)]
+struct SomeFFI([i64; 0]);
+```
+
+Of course, making `SomeFFI` size 8 doesn't work for anyone using `repr(C)` for case 1. They want it to be size 0 (as it currently is). 
+
+# Guide-level explanation
+[guide-level-explanation]: #guide-level-explanation
+
+`repr(ordered_fields)` is a new representation that can be applied to `struct`, `enum`, and `union` to give them a consistent, cross-platform, and predictable in memory layout.
+
+`repr(C)` in edition <= 2024 is an alias for `repr(ordered_fields)` and in all other editions, it matches the default C compiler for the given target for structs, unions, and field-less enums. Enums with fields will be laid out as if they are a union of structs with the corresponding fields.
+
+Using `repr(C)` in editions <= 2024 triggers a lint to use `repr(ordered_fields)` as a future compatibility lint with a machine-applicable fix. If you are using `repr(C)` for FFI, then you may silence this lint. If you are using `repr(C)` for anything else, please switch over to `repr(ordered_fields)` so updating to future editions doesn't change the meaning of your code.
+
+```
+warning: use of `repr(C)` in type `Foo`
+  --> src/main.rs:14:10
+   |
+14 |     #[repr(C)]
+   |       ^^^^^^^ help: consider switching to `repr(ordered_fields)`
+   |     struct Foo {
+   |
+   = note: `#[warn(edition_2024_repr_c)]` on by default
+   = note: `repr(C)` is planned to change meaning in the next edition to match the target platform's layout algorithm. This may change the layout of this type on certain platforms. To keep the current layout, switch to `repr(ordered_fields)`
+```
+
+After enough time has passed, and the community has switched over:
+This makes it easier to tell *why* the `repr` was applied to a given struct. If `repr(C)`, it's about FFI and interop. If `repr(ordered_fields)`, then it's for a dependable layout.
+# Reference-level explanation
+[reference-level-explanation]: #reference-level-explanation
+
+## `repr(C)`
+
+> The `C` representation is designed for one purpose: creating types that are interoperable with the C Language.
+> 
+> This representation can be applied to structs, unions, and enums. The exception is [zero-variant enums](https://doc.rust-lang.org/stable/reference/items/enumerations.html#zero-variant-enums) for which the `C` representation is an error.
+> 
+> - edited version of the [reference](https://doc.rust-lang.org/stable/reference/type-layout.html#the-c-representation) on `repr(C)`
+
+The exact algorithm is deferred to whatever the default target C compiler does with default settings (or if applicable, the most commonly used settings). 
+## `repr(ordered_fields)` 
+
+> The `ordered_fields` representation is designed for one purpose: create types that you can soundly perform operations on that rely on data layout such as reinterpreting values as a different type
+> 
+> This representation can be applied to structs, unions, and enums.
+> 
+> - edited version of the [reference](https://doc.rust-lang.org/stable/reference/type-layout.html#the-c-representation) on `repr(C)`
+### struct
+Structs are laid out in memory in declaration order, with padding bytes added as necessary to preserve alignment.
+And their alignment would be the same as their most aligned field.
+
+```rust
+// size 16, align 4
+#[repr(ordered_fields)]
+struct FooStruct {
+    a: u8,
+    b: u32,
+    c: u16,
+    d: u32,
+}
+```
+
+Would be laid out in memory like so
+
+```
+a...bbbbcc..dddd
+```
+### union
+Unions would be laid out with the same size as their largest field, and the same alignment as their most aligned field. 
+
+```rust
+// size 4, align 4
+#[repr(ordered_fields)]
+union FooUnion {
+    a: u8,
+    b: u32,
+    c: u16,
+    d: u32,
+}
+```
+
+Would have the same layout as `u32`.
+### enum
+The enum discriminant will be the smallest signed integer type which can hold all of the discriminant values (unless otherwise specified). The discriminants are assigned such that each variant without an explicit discriminant is exactly one more than the previous variant in declaration order. 
+
+If an enum doesn't have any fields, then it is represented exactly by it's discriminant. 
+```rust
+// discriminant = i16
+// represented as i16
+#[repr(ordered_fields)]
+enum FooEnum {
+    VarA = 1,
+    VarB, // discriminant = 2
+    VarC = 500,
+    VarD, // discriminant = 501
+}
+
+// discriminant = u16
+// represented as u16
+#[repr(ordered_fields, u16)]
+enum FooEnumUnsigned {
+    VarA = 1,
+    VarB, // discriminant = 2
+    VarC = 500,
+    VarD, // discriminant = 501
+}
+```
+
+Enums with fields will be laid out as if they were a union of structs.
+
+For example, this would be laid out the same as the union below
+```rust
+#[repr(ordered_fields)]
+enum BarEnum {
+    VarFieldless,
+    VarTuple(u8, u32),
+    VarStruct {
+        a: u16,
+        b: u32,
+    },
+}
+```
+
+```rust
+#[repr(ordered_fields)]
+union BarUnion {
+    var1: VarFieldless,
+    var2: VarTuple,
+    var3: VarStruct,
+}
+
+#[repr(ordered_fields)]
+enum BarDiscriminant {
+    VarFieldless,
+    VarTuple,
+    VarStruct,
+}
+
+#[repr(ordered_fields)]
+struct VarFieldless {
+    disc: BarDiscriminant,
+}
+
+#[repr(ordered_fields)]
+struct VarTuple(BarDiscriminant, u8, u32);
+
+#[repr(ordered_fields)]
+struct VarStruct(BarDiscriminant, u16, u32);
+```
+
+In Rust, the algorithm for calculating the layout is defined precisely as follows
+
+```rust
+/// Takes in the layout of each field (in declaration order)
+/// and returns the offsets of each field, and layout of the entire struct
+fn get_layout_for_struct(field_layouts: &[Layout]) -> Result<(Vec<usize>, Layout), LayoutError> {
+    let mut layout = Layout::new::<()>();
+    let mut field_offsets = Vec::new();
+
+    for &field in field_layouts {
+        let (next_layout, offset) = layout.extend(field)?;
+
+        field_offsets.push(offset);
+        layout = next_layout;
+    }
+
+    Ok((field_offsets, layout.pad_to_align()))
+}
+
+fn layout_max(a: Layout, b: Layout) -> Result<Layout, LayoutError> {
+    Layout::from_size_align(
+        a.size().max(b.size()),
+        a.align().max(b.align()),
+    )
+}
+
+/// Takes in the layout of each field (in declaration order)
+/// and returns the layout of the entire union
+/// NOTE: all fields of the union are located at offset 0
+fn get_layout_for_union(field_layouts: &[Layout]) -> Result<Layout, LayoutError> {
+    let mut layout = Layout::new::<()>();
+
+    for &field in field_layouts {
+        layout = layout_max(layout, field)?;
+    }
+
+    Ok(layout.pad_to_align())
+}
+
+/// Takes in the layout of each variant (and their fields) (in declaration order)
+/// and returns the offsets of all fields of the enum, and the layout of the entire enum
+/// NOTE: all fields of the enum discriminant is always at offset 0
+fn get_layout_for_enum(
+    // the discriminants may be negative for some enums
+    // or u128::MAX for some enums, so there is no one primitive integer type which works. So BigInteger
+    discriminants: &[BigInteger],
+    variant_layouts: &[&[Layout]]
+) -> Result<(Vec<Vec<usize>>, Layout), LayoutError> {
+    assert_eq!(discriminants.len(), variant_layouts.len());
+
+    let mut layout = Layout::new::<()>();
+    let mut variant_field_offsets = Vec::new();
+
+    let mut variant_with_disc = Vec::new();
+    // gives the smallest integer type which can represent the variants and the specified discriminants
+    let disc_layout = get_layout_for_discriminant(discriminants);
+    // ensure that the discriminant is the first field
+    variant_with_disc.push(disc_layout);
+
+    for &variant in variant_layouts {
+        variant_with_disc.truncate(1);
+        // put all other fields of the variant after this one
+        variant_with_disc.extend_from_slice(variant);
+        let (mut offsets, variant_layout) = get_layout_for_struct(&variant_with_disc)?;
+        // remove the discriminant so the caller only gets the fields they provided in order
+        offsets.remove(0);
+
+        variant_field_offsets.push(offsets);
+        layout = layout_max(layout, variant_layout)?;
+    }
+
+    Ok((variant_field_offsets, layout))
+}
+```
+### Migration to `repr(ordered_fields)`
+
+The migration will be handled as follows:
+* after `repr(ordered_fields)` is implemented
+    * add a future compatibility warning for `repr(C)` in all current editions
+    * at this point both `repr(ordered_fields)` and `repr(C)` will have identical behavior
+    * the warning will come with a machine-applicable fix
+        * Any crate which does no FFI can just apply the autofix
+        * Any crate which uses `repr(C)` for FFI can ignore the warning crate-wide
+        * Any crate which mixes both must do extra work to figure out which is which. (This is likely a tiny minority of crate)
+* Once the next edition rolls around (2027?), `repr(C)` on the new edition will *not* warn. Instead the meaning will have changed to mean *only* compatibility with C. The docs should be adjusted to mention this edition wrinkle.
+    * The warning for previous editions will continue to be in effect
+* In some future edition (2033+), when it is deemed safe enough, the future compatibility warnings may be removed in editions <= 2024
+    * This should have given plenty of time for anyone who was going to update their code to do so. And doesn't burden the language indefinitely
+    * This part isn't strictly necessary, and can be removed if needed
+
+# Drawbacks
+[drawbacks]: #drawbacks
+
+* This will cause a large amount of churn in the Rust ecosystem
+* If we don't end up switching `repr(C)` to mean the system layout/ABI, then we will have two identical reprs, which may cause confusion.
+# Rationale and alternatives
+[rationale-and-alternatives]: #rationale-and-alternatives
+
+* `crabi`: http://github.com/rust-lang/rfcs/pull/3470
+    * Currently stuck in limbo since it has a much larger scope. doesn't actually serve to give a consistent cross-platform layout, since it defers to `repr(C)` (and it must, for its stated goals)
+* https://internals.rust-lang.org/t/consistent-ordering-of-struct-fileds-across-all-layout-compatible-generics/23247
+    * This doesn't give a predictable layout that can be used to match the layouts (or prefixes) of different structs
+* https://github.com/rust-lang/rfcs/pull/3718
+    * This one is currently stuck due to a larger scope than this RFC
+* do nothing
+    * We keep getting bug reports on Windows (and other platforms), where `repr(C)` doesn't actually match the target C compiler, or we break a bunch of subtle unsafe code to match the target C compiler.
+# Prior art
+[prior-art]: #prior-art
+
+See Rationale and Alternatives as well
+
+* https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/expand.2Frevise.20repr.28.7BC.2Clinear.2C.2E.2E.2E.7D.29.20for.202024.20edition
+
+# Unresolved questions
+[unresolved-questions]: #unresolved-questions
+
+* The migration plan, as a whole, needs to be ironed out
+    * Currently, it is just a sketch, but we need timelines, dates, and guarantees to switch `repr(C)` to match the layout algorithm of the target C compiler.
+    * Before this RFC is accepted, t-compiler will need to commit to fixing the layout algorithm sometime in the next edition.
+* The name of the new repr `repr(ordered_fields)` is a mouthful (intentionally for this RFC), maybe we could pick a better name? This could be done after the RFC is accepted.
+    * `repr(linear)`
+    * `repr(ordered)`
+    * `repr(sequential)`
+    * `repr(consistent)`
+    * something else?
+* Is the ABI of `repr(ordered_fields)` specified (making it safe for FFI)? Or not?
+* Should unions expose some niches?
+    * For example, if all variants of the union are structs which have a common prefix, then any niches of that common prefix could be exposed (i.e. in the enum case, making union of structs behave more like an enum).
+    * This must be answered before stabilization, as it is set in stone after that
+* Should this `repr` be versioned?
+    * This way we can evolve the repr (for example, by adding new niches)
+* Should we change the meaning of `repr(C)` in editions <= 2024 after we have reached edition 2033? Yes, it's a breaking change, but at that point it will likely only be breaking code no one uses.
+    * Leaning towards no
+# Future possibilities
+[future-possibilities]: #future-possibilities
+
+* Add more reprs for each target C compiler, for example `repr(C_gcc)` or  `repr(C_msvc)`, etc.
+    * This would allow a single Rust app to target multiple compilers robustly, and would make it easier to specify `repr(C)`
+    * This would also allow fixing code in older editions
+* https://internals.rust-lang.org/t/consistent-ordering-of-struct-fileds-across-all-layout-compatible-generics/23247