-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add a contains method to VecDeque and LinkedList #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a contains method to VecDeque and LinkedList #1552
Conversation
It's appropriate for most collections, so I'd suggest adding it to |
While it definitely makes sense to do so, we already have an inconsistency here: there already is a
I also want to avoid creating many solutions for one programming task. I can already imagine confused students, asking about the difference of I'm not overly happy with the current system due to inconsistencies, but I think adding |
🔔 This RFC is now entering its week-long final comment period 🔔 Note, though, that the libs team also figured that small RFCs like this which already fit existing conventions are also appropriate to just send a PR :) |
With #1434 merged, if this gets merged we'll have
Certainly there's opportunity for someone to unnecessarily |
The libs team discussed this RFC during triage today and the decision was to merge. Thanks again for the RFC @LukasKalbertodt! |
Tracking issue: rust-lang/rust#32630 |
Summary: add a
contains
method toVecDeque
andLinkedList
that checks if the collection contains a given item.Rendered