Add 'proposed-final-coment-period' label.

[withoutboats]

No description provided.

[anp]

Awesome! Unfortunately CI is failing on a reference/value type mismatch: https://travis-ci.org/dikaiosune/rust-dashboard/jobs/245632172#L804 (can't wait for match ergonomics RFC to land!!!!)

cc @aturon -- I'm assuming that you're good with this and that someone will make sure to create this label on the rust-lang org's repos?

[aturon]

Yep! Thanks @withoutboats for pushing on this!

[withoutboats]

@dikaiosune ahh I've created this already on RFCs, forgot we used this on other repos? What repos does the label need to exist on?

[withoutboats]

also as you can probably tell i am irresponsible and just pushed without testing because i didnt want to set up a db

[anp]

@withoutboats mostly just on rust-lang/rust, although it will technically work on any rust-lang, rust-lang-nursery or rust-lang-deprecated repo. Might want to just ignore the error case rather than ?ing when applying the label so that we don't early return if someone proposes FCP on a repo without the label?

Totally understand on the database. It was super nifty to use when I was building this out and was the only maintainer, but I probably need to explicitly lay out the schema and just add a test that ensures it matches for CI to run. Would make it easier to contribute small, obvious fixes if the db wasn't required to build.

[withoutboats]

Done :) Some other thoughts though:

• When entering actual FCP should probably remove the label. I think we can deploy adding the label without that, though, I'll just follow up on it eventually. Currently there's not a nice label removal abstraction in github::Client.
• I'm thinking about adding a set of disposition tags which it will also set, so that its very easy to see what we're considering doing with this proposal. (It might also be worth adding additional dispositions for the rust repo, right now we just use "merge" as a synonym for "positive inclination").

[anp]

Sounds great. Also see #89 (comment) for some previous discussion of a wider variety of rust-lang/rust commands and multiple FCP timeframes.

[anp]

onoes https://travis-ci.org/dikaiosune/rust-dashboard/jobs/245906044#L805

[anp]

thanks!