Document unsafety #280
Merged
Document unsafety #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
force-pushed
the
feature/document-unsafety
branch
2 times, most recently
from
bdf5ec7 to
6202515
Compare
calebzulawski
force-pushed
the
feature/document-unsafety
branch
from
6202515 to
05c92c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173. Clippy no longer crashes on this 🙂
I also made the bitmask traits safe, since implementing them isn't really unsafe. The bitmask conversion functions are themselves safe but contain documented unsafe blocks.