Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #3313 partially for me. Previously, none of the miri tests could even build. Now they all pass :).
There is a lingering issue that I don't quite understand yet, which is that attempting to do
miri test
with another crate can still having aborting behavior.The motivating example I have is https://github.com/PSeitz/lz4_flex, and how I found the issue to begin with. I can now build the test binaries, but now it immediately fails upon test execution with
(exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)
(Windows).It appears something is still being build with
panic="abort"
somewhere, but adding it to the other cargo invocation did not seem to solve itmiri/cargo-miri/src/phases.rs
Line 115 in 92110c2
-Cpanic=unwind
as a test but the abort still occurred. And to note, the tests run fine without touching the cargo config and runningcargo test
.