Skip to content

Force panic=unwind for sysroot #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RossSmyth
Copy link
Contributor

This fixed #3313 partially for me. Previously, none of the miri tests could even build. Now they all pass :).

There is a lingering issue that I don't quite understand yet, which is that attempting to do miri test with another crate can still having aborting behavior.

The motivating example I have is https://github.com/PSeitz/lz4_flex, and how I found the issue to begin with. I can now build the test binaries, but now it immediately fails upon test execution with (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION) (Windows).

It appears something is still being build with panic="abort" somewhere, but adding it to the other cargo invocation did not seem to solve it

let mut cmd = cargo();
somewhere after here I unconditionally put -Cpanic=unwind as a test but the abort still occurred. And to note, the tests run fine without touching the cargo config and running cargo test.

@RalfJung
Copy link
Member

Can we set of build profile of "miri_sysroot" so that if people changed things about their "release" profile that just doesn't affect us?

@RossSmyth
Copy link
Contributor Author

Can we set of build profile of "miri_sysroot" so that if people changed things about their "release" profile that just doesn't affect us?

Probably? Now that you say that I think this PR probably isn't the way to go.

@RossSmyth RossSmyth closed this Feb 24, 2024
@RossSmyth RossSmyth deleted the panic-abort-ignore branch February 25, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken sysroot when custom "release" profile sets panic="abort"
3 participants