Skip to content

CONTRIBUTING.md: Use build --stage 1 instead of build --stage 2 #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2020
Merged

CONTRIBUTING.md: Use build --stage 1 instead of build --stage 2 #1612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb59980
CONTRIBUTING.md: Use `build --stage 1` instead of `build --stage 2`
camelid Oct 30, 2020
6a475c3
CONTRIBUTING.md: Update comment
camelid Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,20 +142,20 @@ tracing) enabled.
The setup for a local rustc works as follows:
```sh
# Clone the rust-lang/rust repo.
git clone https://github.com/rust-lang/rust/ rustc
git clone https://github.com/rust-lang/rust rustc
cd rustc
cp config.toml.example config.toml
# Now edit `config.toml` and set `debug-assertions = true`.

# Build a stage 2 rustc.
# Build a stage 1 rustc, and build the rustc libraries with that rustc.
# This step can take 30 minutes or more.
./x.py build --stage 2 compiler/rustc
./x.py build --stage 1 compiler/rustc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why compiler/rustc is necessary, but that's a mystery for another day.

# If you change something, you can get a faster rebuild by doing
./x.py build --keep-stage 0 --stage 2 compiler/rustc
./x.py build --keep-stage 0 --stage 1 compiler/rustc
# You may have to change the architecture in the next command
rustup toolchain link custom build/x86_64-unknown-linux-gnu/stage2
rustup toolchain link stage1 build/x86_64-unknown-linux-gnu/stage1
# Now cd to your Miri directory, then configure rustup
rustup override set custom
rustup override set stage1
```

With this, you should now have a working development setup! See
Expand Down