-
Notifications
You must be signed in to change notification settings - Fork 386
Check that shims are called with the correct number of arguments #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☔ The latest upstream changes (presumably #1299) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi @toc-the-younger, welcome and thank you so much for your first PR here! |
☔ The latest upstream changes (presumably #1324) made this pull request unmergeable. Please resolve the merge conflicts. |
In case it got lost, I left a comment a few days ago: #1298 (comment). |
☔ The latest upstream changes (presumably #1284) made this pull request unmergeable. Please resolve the merge conflicts. |
Could you add a testcase for some intrinsic and some foreign item that we call with too few / too many arguments? (There's no point in testing all of them, but we should at least cover one, I think.) |
Also please rebase, we prefer not to have merge conflicts in PRs. |
#1390 added a new shim which also needs to be added here. |
This looks great, thanks a lot. :-) |
📌 Commit f741f2c has been approved by |
☀️ Test successful - checks-travis, status-appveyor |
Fixes #1272
Some shims don't use all their arguments, I've assumed they are being called in tests with the correct number of arguments here.