Skip to content

Check that shims are called with the correct number of arguments #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2020
Merged

Check that shims are called with the correct number of arguments #1298

merged 6 commits into from
May 5, 2020

Conversation

al-yisun
Copy link
Contributor

@al-yisun al-yisun commented Apr 2, 2020

Fixes #1272

Some shims don't use all their arguments, I've assumed they are being called in tests with the correct number of arguments here.

al-yisun
al-yisun commented Apr 2, 2020
View reviewed changes
@bors
Copy link
Contributor

bors commented Apr 2, 2020

☔ The latest upstream changes (presumably #1299) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member

RalfJung commented Apr 3, 2020

Hi @toc-the-younger, welcome and thank you so much for your first PR here!
I'll add reviewing this to my queue, but as you can see there are some older PRs I have to get to first, so please don't be worried when it takes a bit for me tog et back to you.

@RalfJung RalfJung mentioned this pull request Apr 3, 2020
Closed
RalfJung
RalfJung reviewed Apr 7, 2020
View reviewed changes
RalfJung
RalfJung reviewed Apr 7, 2020
View reviewed changes
RalfJung
RalfJung reviewed Apr 7, 2020
View reviewed changes
@bors
Copy link
Contributor

bors commented Apr 12, 2020

☔ The latest upstream changes (presumably #1324) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member

eddyb commented Apr 12, 2020

In case it got lost, I left a comment a few days ago: #1298 (comment).

@RalfJung RalfJung added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Apr 18, 2020
al-yisun
al-yisun commented Apr 29, 2020
View reviewed changes
@bors
Copy link
Contributor

bors commented Apr 30, 2020

☔ The latest upstream changes (presumably #1284) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung
RalfJung reviewed Apr 30, 2020
View reviewed changes
RalfJung
RalfJung reviewed Apr 30, 2020
View reviewed changes
RalfJung
RalfJung reviewed Apr 30, 2020
View reviewed changes
@RalfJung
Copy link
Member

Could you add a testcase for some intrinsic and some foreign item that we call with too few / too many arguments? (There's no point in testing all of them, but we should at least cover one, I think.)

@RalfJung
Copy link
Member

Also please rebase, we prefer not to have merge conflicts in PRs.

RalfJung
RalfJung reviewed May 1, 2020
View reviewed changes
RalfJung
RalfJung reviewed May 1, 2020
View reviewed changes
@RalfJung
Copy link
Member

RalfJung commented May 3, 2020

#1390 added a new shim which also needs to be added here.

@RalfJung
Copy link
Member

RalfJung commented May 5, 2020

This looks great, thanks a lot. :-)
@bors r+

@bors
Copy link
Contributor

bors commented May 5, 2020

📌 Commit f741f2c has been approved by RalfJung

@bors
Copy link
Contributor

bors commented May 5, 2020

⌛ Testing commit f741f2c with merge 2f974f6...

@bors
Copy link
Contributor

bors commented May 5, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 2f974f6 to master...

@bors bors merged commit 2f974f6 into rust-lang:master May 5, 2020
@al-yisun al-yisun deleted the check-arg-count branch May 5, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: Waiting for the PR author to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check number of arguments for shims
4 participants
@al-yisun @bors @RalfJung @eddyb