Skip to content

Conversation

xbjfk
Copy link
Contributor

@xbjfk xbjfk commented May 1, 2025

Description

Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. This fixes #3305. This change type can probably be changed and this commit reverted when #3068 is merged.

Sources

diff
permalink

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see rust-lang/libc#3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305
@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels May 1, 2025
@xbjfk xbjfk mentioned this pull request May 1, 2025
3 tasks
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@tgross35 tgross35 added this pull request to the merge queue May 1, 2025
Merged via the queue into rust-lang:main with commit 4cdbb5e May 1, 2025
50 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305

(cherry picked from commit aa08592)
(backport <rust-lang#4438>)
@tgross35 tgross35 mentioned this pull request May 28, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305

(cherry picked from commit aa08592)
(backport <rust-lang#4438>)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305

(backport <rust-lang#4438>)
(cherry picked from commit aa08592)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305

(backport <rust-lang#4438>)
(cherry picked from commit aa08592)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 1, 2025
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305

(backport <rust-lang#4438>)
(cherry picked from commit aa08592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run tests in libc-test using musl (Alpine Linux 3.18.2)
3 participants