Revise generate function to return Result #4430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Add anyhow error handling. Revert expect call in generate API
tgross35
requested changes
Apr 28, 2025
ctest/src/lib.rs
Outdated
| use std::collections::{HashMap, HashSet}; | ||
| use std::env; | ||
| use std::fs::File; | ||
| use std::io::prelude::*; | ||
| use std::io::BufWriter; | ||
| use std::panic::{catch_unwind, AssertUnwindSafe}; |
There was a problem hiding this comment.
Unfortunately we can't use catch_unwind; if somebody has panic = abort in their Cargo.toml or if run on a target/backend that doesn't support unwinding, the program will stop and catch_unwind won't actually catch anything. All functions that may return an error need to change their signature then update .unwrap() / .expect() to ?.
Everything else looks pretty good to me, but I'll re-review after the changes.
(basically my same comment from #4424 (comment))
There was a problem hiding this comment.
Thanks. I've removed the remaining catch_unwind logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #4369 , the generate function should return a Result instead of returning nothing.
This PR is a continuation of #4424 which was closed due to bad rebase.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI