Skip to content

Add MS_NOSYMFOLLOW flag #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

tedbrandston
Copy link

Description

Adds the MS_NOSYMFOLLOW flag from linux/mount.h

MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks.

Sources

https://github.com/torvalds/linux/blob/ab59a8605604f71bbbc16077270dc3f39648b7fc/include/uapi/linux/mount.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. 

See:
torvalds/linux@dab741e
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine but semver/linux.txt needs to be updated. Any reason this is marked as a draft?

@tedbrandston
Copy link
Author

The template said to mark it as a draft if you weren't sure about the checklist items.

I'll take a look at updating the semver, but won't have a chance to test locally for a while. Is local testing necessary for a change like this?

@tgross35
Copy link
Contributor

It's usually good to run locally if possible but don't worry about it here, CI covers testing for this platform. Just update the semver file and squash and this should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants