freebsd add basic ethernet frames support#4252
freebsd add basic ethernet frames support#4252devnexen wants to merge 1 commit intorust-lang:mainfrom
Conversation
devnexen
force-pushed
the
fbsd_ethernet
branch
from
2fd85cc to
b5ff627
Compare
| } | ||
| } | ||
|
|
||
| // FIXME(msrv): `derive` on packed structs cannot be used below 1.67 |
There was a problem hiding this comment.
That sounds to me like a compelling reason to raise the main branch's MSRV. Why is it currently set to 1.63?
There was a problem hiding this comment.
1.63 is what Debian stable currently ships so it is a pretty common baseline in the ecosystem. In a few months Trixie will be released 1.83 (or higher) so we will probably be able to do another bump (not that high, but at least above 1.63).
There was a problem hiding this comment.
Stumbled across this again because considering a MSRV bump: what exactly happened at 1.67? Derive on packed structs seems to work all the way down to 1.0 https://rust.godbolt.org/z/qqPsT46zr.
Derive on packed structs without Copy is a newer feature as of 1.69, but everything we have is Copy anyway
| } | ||
|
|
||
| pub {const} fn ETHER_IS_MULTICAST(addr: *mut u_char) -> bool { | ||
| (*addr.wrapping_add(0)) & 0x01 != 0x00 |
There was a problem hiding this comment.
I'm surprised that Clippy doesn't complain about the uselessness of wrapping_add(0).
|
@rustbot author could you remove |
devnexen
force-pushed
the
fbsd_ethernet
branch
3 times, most recently
from
856cad1 to
75aaf74
Compare
devnexen
force-pushed
the
fbsd_ethernet
branch
from
b8215f3 to
bd5186e
Compare
devnexen
force-pushed
the
fbsd_ethernet
branch
from
bd5186e to
7a89e71
Compare
4 participants
reference