Skip to content

chore: replace num_cpus with available_parallelism #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taiki-e merged 4 commits into from
May 23, 2025
Merged

chore: replace num_cpus with available_parallelism #2946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bc953e
chore: replace num_cpu with available_parallelism
tisonkun Apr 8, 2025
2ccc563
Merge branch 'master' into replace-numcpu-with-available_parallelism
tisonkun May 19, 2025
e467e26
fixup clippy checks
tisonkun May 19, 2025
2c82199
try tell a minimal libc version
tisonkun May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions futures-executor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@ Executors for asynchronous tasks based on the futures-rs library.
[features]
default = ["std"]
std = ["futures-core/std", "futures-task/std", "futures-util/std"]
thread-pool = ["std", "num_cpus"]
thread-pool = ["std"]

[dependencies]
futures-core = { path = "../futures-core", version = "=1.0.0-alpha.0", default-features = false }
futures-task = { path = "../futures-task", version = "=0.4.0-alpha.0", default-features = false }
futures-util = { path = "../futures-util", version = "=0.4.0-alpha.0", default-features = false }
num_cpus = { version = "1.8.0", optional = true }

[dev-dependencies]
futures = { path = "../futures", features = ["thread-pool"] }
Expand Down
10 changes: 2 additions & 8 deletions futures-executor/src/thread_pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use futures_task::{waker_ref, ArcWake};
use futures_task::{FutureObj, Spawn, SpawnError};
use futures_util::future::FutureExt;
use std::boxed::Box;
use std::cmp;
use std::fmt;
use std::format;
use std::io;
Expand Down Expand Up @@ -190,13 +189,8 @@ impl ThreadPoolBuilder {
///
/// See the other methods on this type for details on the defaults.
pub fn new() -> Self {
Self {
pool_size: cmp::max(1, num_cpus::get()),
stack_size: 0,
name_prefix: None,
after_start: None,
before_stop: None,
}
let pool_size = thread::available_parallelism().map_or(1, |p| p.get());
Self { pool_size, stack_size: 0, name_prefix: None, after_start: None, before_stop: None }
}

/// Set size of a future ThreadPool
Expand Down