feat: add _timeout variants to blocking executions
#2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce `block_on_timeout`, as well as `LocalPool::run_timeout` and `LocalPool::run_until_timeout`. The internal `run_executor` has been modified to use either `std::thread::park` or `std::thread::park_timeout`. In case of timeout, a `TimeoutError` instance is returned. The new generic `run_executor_impl` returns a `Result`, which is always `Ok` in `run_executor` case (using `park`). It has been checked with `cargo asm` that the compiler is able to elide the `unwrap` call in this case. Also, the assembly showed that the parking closure was inlined, so no regression is expected compared to the previous implementation.
|
Resolves #2911 |
It allows removing the private field. This pattern is used for example by `std::thread::AccessError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce
block_on_timeout, as well asLocalPool::run_timeoutandLocalPool::run_until_timeout. The internalrun_executorhas been modified to use eitherstd::thread::parkorstd::thread::park_timeout. In case of timeout, aTimeoutErrorinstance is returned.The new generic
run_executor_implreturns aResult, which is alwaysOkinrun_executorcase (usingpark). It has been checked withcargo asmthat the compiler is able to elide theunwrapcall in this case. Also, the assembly showed that the parking closure was inlined, so no regression is expected compared to the previous implementation.