-
Notifications
You must be signed in to change notification settings - Fork 656
Allow async-await macros to be used without std #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wanted to also address
I'm probably reading too much into it given how weak the randomness requirement here really is but I left that out for now... though I am tempted to leave the macro itself in so it could still be used if you override the random fn using a facade. |
(FYI: There is a discussion in #1805 about adding a select that doesn't use randomness. and seems implementation is not difficult: taiki-e@2691aa2) |
Yeah that would be really nice, is there anything blocking that from becoming a PR? just docs? or name, default, syntax bikeshed? uncertainty around whether it should be provided? |
I didn't open the PR because the document was incomplete, but in practice, we will need to decide which is the default. |
Yeah, I can see the argument made for keeping unbiased as the default, though don't have any personal opinions there as long as the ability to choose can be made available. Also, I threw up what I had for no-std random and could PR in case it's something that could be accepted? |
3a8561a
to
bd745d3
Compare
bd745d3
to
541a2ae
Compare
@arcnmx firstly thanks for looking at this, |
541a2ae
to
dbb0164
Compare
Rebased onto master, so |
dbb0164
to
e8096cd
Compare
e8096cd
to
f5c6439
Compare
`select!()` is the only macro that requires std due to implementation details, so allow everything else through.
f5c6439
to
9d8f56e
Compare
@taiki-e you've approved this previously, any chance it could be considered for merging? I've been experimentally making use of these changes for quite a while now and it'd be nice to have these available upstream - it seems like a benign change, and (cc @Nemo157 as this is somewhat your domain as well) |
I'd like to merge this. cc @cramertj |
This looks fine to me, thanks for the ping! I'll get a release out shortly. |
select!()
is the only macro that requires std due to implementation details, so allow everything else through.