fix order, and delimiting and trailing comma for repr attribute
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `repr()` attribute allows definitions to be specified in any order:
#[repr(C, align(64))]
struct Foo(i32);
#[repr(align(64), C)]
struct Bar(i32);
They can also only have `Alignment` present:
#[repr(align(64))]
struct Baz(i32);
And a trailing comma:
#[repr(packed,)]
struct Qux(i32);
In addition, previous version of the `Representation` category did not
require a delimiting comma (`repr(C packed)`).
To fix these issues, introduce a list of representations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
repr()attribute allows definitions to be specified in any order:They can also only have
Alignmentpresent:And a trailing comma:
In addition, previous version of the
Representationcategory did not require a delimiting comma (repr(C packed)).To fix these issues, introduce a list of representations.