Implement token scope restrictions for our endpoints #5572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
token-scope-endpoints
branch
from
ea71d88 to
07a825c
Compare
Turbo87
force-pushed
the
token-scope-endpoints
branch
from
07a825c to
50563ff
Compare
Turbo87
force-pushed
the
token-scope-endpoints
branch
from
50563ff to
3399875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts our
AuthCheckcalls for the three relevant endpoints (publish, change owner, yank) to check the token scope restrictions if the token has any.Note that for the publish operation we unfortunately need an extra database query to determine if the request is trying to publish a new crate or a new version for an existing crate. This query is performed outside of the existing database transaction since we have somewhat relaxed consistency requirements here.
In the worst case, two new crates with the same name are published concurrently, which would require both requests to have a
publish-newtoken scope.Related: