WIP: Implement basic token scopes #5528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
|
☔ The latest upstream changes (presumably bf05e26) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
basic-token-scopes
branch
9 times, most recently
from
387d65d to
1acd799
Compare
|
☔ The latest upstream changes (presumably 3acb400) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
basic-token-scopes
branch
from
1acd799 to
3ecd7c1
Compare
Turbo87
force-pushed
the
basic-token-scopes
branch
from
3ecd7c1 to
46f6a21
Compare
|
closing this as it has been replaced by a few other (merged) PRs 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress!
It will add token scope columns to the database and check these columns in the route handlers that require authentication. It will not add support for creating such tokens to the API yet, or change the frontend in any way.
This will allow us to test these changes in production with a very limited number of tokens that already have these scopes set manually in the database.
Also, please consider the code in this PR prototype quality for now. The goal was to get to something that works, and now begins the part of cleaning it up, making it production quality and extracting dedicated commits/PRs from it.
see #5443