Mark API tokens as revoked #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR, when a user deletes an API token, rather than deleting it from the database, it will instead be marked as `revoked`. That means that this PR also adds a migration to add the column `revoked` to the `api_tokens` table.
carols10cents
approved these changes
Dec 3, 2018
|
Thanks! Looks great!!! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 3, 2018
1567: Mark API tokens as revoked r=carols10cents a=joshleeb With this PR, when a user deletes an API token, rather than deleting it from the database, it will instead be marked as `revoked`. That means that this PR also adds a migration to add the column `revoked` to the `api_tokens` table. Ref. #1548 (Task 1) Co-authored-by: Josh Leeb-du Toit <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, when a user deletes an API token, rather than deleting it from the database, it will instead be marked as
revoked.That means that this PR also adds a migration to add the column
revokedto theapi_tokenstable.Ref. #1548 (Task 1)