Used crate ID for background jobs

[YohDeadfall]

Should the jobs store crate names for logging purposes? Or should they just show the provided ID instead?

[Turbo87]

Fixes #11349

I will remove that part of the issue description, since a) this is only covering one of the problematic jobs, and b) this job will also need a follow-up PR to migrate away from Option<i32> to i32.

[Turbo87]

it's probably easiest to keep using name for now and migrate over to crate_id in the next PR when this PR here has been deployed to production. That way we won't need the load_crate_id() fn at all :)

[YohDeadfall]

So, the first step is only for adding identifiers to the jobs without changing how they work, right?

[Turbo87]

yeah, exactly. that should make it easier to migrate them.

[YohDeadfall]

I will remove that part of the issue description

That's why it's only a draft. I have some questions and would like to deal with them first on a single job, and then do the same for the rest.

[YohDeadfall]

A side question. Does it makes sense to provide configuration files for the analyzer as it's done in Miri and Rust itself? An example: rust-lang/miri@d835aee.

[Turbo87]

Does it makes sense to provide configuration files for the analyzer as it's done in Miri and Rust itself?

idk, I use the JetBrains IDEs, so I don't use rust-analyzer 😅

[YohDeadfall]

If I'm not wrong then it's still rust-analyzer based, but it can be provided by the IDE itself. Anyway, we can live without adding these configs as no one complained except me, and I fixed it locally.

[YohDeadfall]

So, DeleteCrateFromStorage uses name only as it never fetches something by it. Meanwhile, it's created when there's no crate exists:

crates.io/src/bin/crates-admin/delete_crate.rs

Lines 106 to 112 in 7722638

	info!("{name}: Skipped missing crate");
	};
	info!("{name}: Enqueuing background jobs…");
	let git_index_job = jobs::SyncToGitIndex::new(name);
	let sparse_index_job = jobs::SyncToSparseIndex::new(name);
	let delete_from_storage_job = jobs::DeleteCrateFromStorage::new(name.into());

Is it a bug or a feature?

[Turbo87]

DeleteCrateFromStorage uses name only as it never fetches something by it.

hmm, I guess in that case we should probably keep using the name since we can't delete by ID anyway.

Meanwhile, it's created when there's no crate exists. Is it a bug or a feature?

that is actually intentional. we had a couple of cases in the past where a crate was deleted from the database by our support team but wasn't removed from S3 storage. this implementation allowed us to remove it from storage even though it didn't exist in the database anymore.

[YohDeadfall]

That's unintentional and will be removed. It fixes the issue with helix at least.