Skip to content

Update contribution guidelines to use --index #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

Deedasmi
Copy link
Contributor

Introduced in rust-lang/cargo#4209

@kureuil
Copy link
Contributor

kureuil commented Sep 26, 2017

Thanks for the pull request @Deedasmi :)

If I remember correctly cargo isn't automatically updated, so wouldn't it be safer to keep the old flag in the documentation, and specify the version ranges compatible with each flag (of course, we'd make --index the default) ?

What happens when you run cargo publish --host file:///path/to/your/crates.io/checkout/tmp/index-co on the latest cargo version ?

@Deedasmi
Copy link
Contributor Author

A friendly deprecation warning saying --host is no longer valid, and that it will 'soon' become a hard error.

I do believe rustup update automatically updates cargo, so most should be getting updated sooner rather than later. I'm cool with adding a footnote or just closing this and revisiting it later, after a couple more updates.

@kureuil
Copy link
Contributor

kureuil commented Sep 26, 2017

I think leaving a footnote for old versions of cargo is enough for now 👍

Believe it's cargo versions < 0.20
@carols10cents
Copy link
Member

Love it!!! Thank you!!

bors: r+

@bors-voyager
Copy link
Contributor

bors-voyager bot commented Sep 27, 2017

Merge conflict (retrying...)

bors-voyager bot added a commit that referenced this pull request Sep 28, 2017
1086: Update contribution guidelines to use --index r=carols10cents

Introduced in rust-lang/cargo#4209
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Sep 28, 2017

Build succeeded

@bors-voyager bors-voyager bot merged commit 03a95c5 into rust-lang:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants