controllers/krate/metadata: Add support for default_version include mode
#10288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
include-default-version
branch
from
aa1833a to
6c191f9
Compare
eth3lbert
force-pushed
the
include-default-version
branch
3 times, most recently
from
1b1be41 to
5e2da2c
Compare
Turbo87
reviewed
Dec 30, 2024
...routes/crates/snapshots/crates_io__tests__routes__crates__read__include_default_version.snap
Outdated
Show resolved
Hide resolved
src/tests/routes/crates/snapshots/crates_io__tests__routes__crates__read__new_name.snap
Outdated
Show resolved
Hide resolved
eth3lbert
force-pushed
the
include-default-version
branch
from
5e2da2c to
c27c857
Compare
… mode This allows us to respond with a version data of `default_version` included, which potentially benefits apps by eliminating the need to wait for the crate response to obtain the default version and then make a subsequent request to get the actual version data. This is particularly useful when we move towards not requesting with `versions` included.
eth3lbert
force-pushed
the
include-default-version
branch
from
c27c857 to
60142dc
Compare
Turbo87
approved these changes
Dec 31, 2024
eth3lbert
commented
Dec 31, 2024
...routes/crates/snapshots/crates_io__tests__routes__crates__read__include_default_version.snap
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to respond with a version data of
default_versionincluded, which potentially benefits apps by eliminating the need to wait for the crate response to obtain thedefault_versionand then make a subsequent request to get the actual version data. This is particularly useful when we move towards not requesting withversionsincluded.