Require target_has_atomic = "ptr" for runtime feature detection
#909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `feature_detect` module is currently being built on all targets, but
the use of `AtomicU32` causes a problem if atomics are not available
(such as with `bpfel-unknown-none`). Gate this module behind
`target_has_atomic = "ptr"`.
The below now completes successfully:
cargo build -p compiler_builtins --target=bpfel-unknown-none -Z build-std=core
Fixes: rust-lang#908
tgross35
force-pushed
the
runtime-detection-atomic
branch
from
d8643a5 to
13b95eb
Compare
Amanieu
approved these changes
May 6, 2025
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
May 6, 2025
Includes the following changes: * Require `target_has_atomic = "ptr"` for runtime feature detection [1]: rust-lang/compiler-builtins#909
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2025
Update `compiler-builtins` to 0.1.158 Includes the following changes: * Require `target_has_atomic = "ptr"` for runtime feature detection [1] [1]: rust-lang/compiler-builtins#909
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2025
Rollup merge of rust-lang#140724 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.158 Includes the following changes: * Require `target_has_atomic = "ptr"` for runtime feature detection [1] [1]: rust-lang/compiler-builtins#909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
feature_detectmodule is currently being built on all targets, but the use ofAtomicU32causes a problem if atomics are not available (such as withbpfel-unknown-none). Gate this module behindtarget_has_atomic = "ptr".The below now completes successfully:
Fixes: #908