Skip to content

Add pow functions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2016
Merged

Add pow functions #82

merged 2 commits into from
Oct 4, 2016

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Sep 30, 2016 •
edited
Loading

I still want to clean up the commit history, but otherwise I think this is complete. Can you run the tests on it?

@mattico mattico force-pushed the add_pow branch 2 times, most recently from 2a949d3 to 38271f6 Compare October 1, 2016 00:32
@mattico
Copy link
Contributor Author

mattico commented Oct 1, 2016

Squashed everything but will need rebase after #84.

@homunkulus
Copy link
Contributor

☔ The latest upstream changes (presumably 89ebc46) made this pull request unmergeable. Please resolve the merge conflicts.

@mattico
Copy link
Contributor Author

mattico commented Oct 3, 2016

Rebased. Should be mergable now.

@japaric
Copy link
Member

japaric commented Oct 3, 2016

Can't review right now so I'm just going to pass this homu for testing.

@homunkulus try

@homunkulus
Copy link
Contributor

⌛ Trying commit 6622c49 with merge 6622c49...

@homunkulus
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
State: approved= try=True

@japaric
Copy link
Member

japaric commented Oct 3, 2016

LGTM. We should also stop compiling the compiler-rt implementations of these in build.rs. I'm actually surprised this PR didn't generate an error due to duplicate symbols ... perhaps, the related test I added is not working properly.

@japaric
Copy link
Member

japaric commented Oct 4, 2016

@homunkulus try

stop compiling compiler-rt implementations
ff7e3ba 
to avoid duplicate symbols
@japaric
Copy link
Member

japaric commented Oct 4, 2016

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit ff7e3ba has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit ff7e3ba with merge 8652c66...

japaric pushed a commit that referenced this pull request Oct 4, 2016
@homunkulus
Auto merge of #82 - mattico:add_pow, r=japaric
8652c66 
Add pow functions

I still want to clean up the commit history, but otherwise I think this is complete. ~~Can you run the tests on it?~~
@homunkulus
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 8652c66 to master...

@homunkulus homunkulus merged commit ff7e3ba into rust-lang:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattico @homunkulus @japaric