test: allow some flexibility in check::error_from_deep_recursion's expected diagnostic. #7826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected diagnostic.
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ seams reasonable. |
|
📌 Commit 4d3b738 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 24, 2020
test: allow some flexibility in check::error_from_deep_recursion's expected diagnostic. This should unblock rust-lang/rust#68407, by loosening the expected output pattern. As per rust-lang/rust#68407 (comment), this is the change in the diagnostic: ```diff -recursion limit reached while expanding the macro `m` +recursion limit reached while expanding `m!` ``` Ideally I would use something like this regex: ``` recursion limit reached while expanding (the macro `m`|`m!`) ``` but AFAIK these tests don't support regexes.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unblock rust-lang/rust#68407, by loosening the expected output pattern.
As per rust-lang/rust#68407 (comment), this is the change in the diagnostic:
Ideally I would use something like this regex:
but AFAIK these tests don't support regexes.