Skip to content

Add ensure option to cargo install #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

k-nasa
Copy link
Contributor

@k-nasa k-nasa commented Jan 23, 2019

Description

Add 'ensure'opsion to cargo_install
Options to prevent errors when crate is already installed.

Background

#6485

I think that this issue is made up of two things.

  • If it is already installed, it will terminate normally
  • Check for the same thing before downloading

This PR solves the first one.
I'll add the second correspondence later.

I ended up using std :: process :: exit. I would like to ask a review if this is OK

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

.arg(
opt(
"ensure",
"Simply leaves it as-is when you already have a suitable version",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the optional help wording

@k-nasa
Copy link
Contributor Author

k-nasa commented Jan 23, 2019

I thought that this PR was not appropriate.
Close once

@k-nasa k-nasa closed this Jan 23, 2019
@k-nasa k-nasa deleted the add_ensure_option_to_cargo_install branch January 23, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants