cargo fix: Pass --all-targets to cargo fix by default
#5814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
I think you mean fixes #5739. Are there precedents of irregularity in compile option passing between commands? |
killercup
changed the title
--all-targets to cargo fix by default--all-targets to cargo fix by default
This'll help fix as much code as possible, including tests! Closes rust-lang#5739
Oops, indeed!
I remembered yesterday that |
alexcrichton
force-pushed
the
fix-all-targets
branch
from
d7d50d9 to
ff8a95e
Compare
|
@bors: r+ |
|
📌 Commit ff8a95e has been approved by |
bors
added a commit
that referenced
this pull request
Jul 30, 2018
cargo fix: Pass `--all-targets` to `cargo fix` by default This'll help fix as much code as possible, including tests! Closes #5739
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll help fix as much code as possible, including tests!
Closes #5739