switch to using the --edition flag #5410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! We’ve tried it some, and at that time there were no nightly with this flag. Let’s try again? @bors r+ |
|
📌 Commit 0b2aaaf has been approved by |
|
⌛ Testing commit 0b2aaaf with merge 3679589d1b1aef703935052c2e9dbfb57bdb1afc... |
|
💔 Test failed - status-appveyor |
|
same failure as my earlier PR #5408 |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 0b2aaaf has been approved by |
bors
added a commit
that referenced
this pull request
Apr 27, 2018
switch to using the --edition flag Now that we have an `--edition` flag in the rust compiler, let's switch to using it. fixes #5406
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have an
--editionflag in the rust compiler, let's switch to using it.fixes #5406