Revert serialization of features to string type #5292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eh2406
reviewed
Apr 4, 2018
| S: Serializer, | ||
| { | ||
| use self::FeatureValue::*; | ||
| match *self { |
There was a problem hiding this comment.
shorter, but less performance code is: serializer.serialize_str(*self.to_string()). But this works too.
There was a problem hiding this comment.
Yeah -- it's only 7 low-complexity extra lines to avoid the allocations on the common path. I figured it was worth it.
There was a problem hiding this comment.
Ok, then this looks good to me. 👍
|
@bors: r+ Thanks for the quick fix! |
|
📌 Commit 540bd45 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally broken during #5270 and only noticed after merge.
cc @matklad @Eh2406