[beta] Don't set MAKEFLAGS for build scripts #4276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
alexcrichton
changed the title
|
@bors: r+ p=1 |
|
📌 Commit a9237f9 has been approved by |
|
Should we document |
|
Yes I can do that as a follow-up |
|
⌛ Testing commit a9237f9530fe30a557b2ab844afc1c62b91e5dcc with merge aec5bbe2822f8b167f998bafa1dbda3ce2136897... |
|
💔 Test failed - status-travis |
|
@bors: r+ |
|
📌 Commit 5186849 has been approved by |
|
⌛ Testing commit 5186849 with merge 468dcf6e1217a9546b1528a5f2a9719a7ac90e6c... |
|
💔 Test failed - status-appveyor |
Needed by rust-lang/rust#42938 I've now ripgrepped for "panicked at" and found no further test that hardcodes the "filename:line$" format.
|
@bors: r+ |
|
📌 Commit 931aec1 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2017
[beta] Don't set MAKEFLAGS for build scripts Closes #4156 Closes rust-lang/rust#42635
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4156
Closes rust-lang/rust#42635