Skip to content

Add path to executable in error #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mattscamp
Copy link
Contributor

Returns the path to the exec that failed on error. Ref: #2529

@alexcrichton
Copy link
Member

Thanks for the PR! I wonder though if perhaps we should thread through the name of the test rather than the path to the executable? We could provide an error message along the lines of:

error: test failed, to rerun pass `--test foo`

That way we can handle failures like "pass --doc", "pass --lib", or "pass --test name-of-weird-thing"

@mattscamp
Copy link
Contributor Author

Great idea. I will work on the changes. Thanks for the feedback!

@alexcrichton
Copy link
Member

ping @mattscamp, any update on this? (I can help out if needed)

@mattscamp
Copy link
Contributor Author

mattscamp commented Jul 28, 2016

Sorry, been caught up with work lately. If I remember right, I had this finished, except it doesn't work on inline tests that are not in their own files. So if I have inline tests, it returns "pass --{name of test}", but that doesn't actually work when you pass it because it's not the name of a test file. I will try to take a look today or push it to a branch for someone else to jump on it!

@alexcrichton
Copy link
Member

@mattscamp ok thanks for the update! And no worries if you're busy, was just curious :)

@bors
Copy link
Contributor

bors commented Sep 26, 2016

☔ The latest upstream changes (presumably #3091) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants