Basic work for cargo install

[steveklabnik]

As a sort of successor to #1318, and as an implementation of https://github.com/rust-lang/rfcs/blob/master/text/1200-cargo-install.md , here's a starting skeleton for cargo install.

As someone not mega familiar with Cargo's internals, this is the point where stuff started to bog down a bit. As you can see, this is mostly getting the setup going, it doesn't work at all yet. Any pointers on where to look at Cargo to see examples of how to do the rest? I'll be poking around myself, but I figure I'd send a PR anyway.

[rust-highfive]

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

[frewsxcv]

specifed

typo

[steveklabnik]

hehe, I copied straight from the RFC...

[huonw]

r? @alexcrichton

[carols10cents]

Hi Steve! I just so happen to be working with cargo internals recently too :) I'm not sure exactly what you're looking for examples of, but I have some guesses. Wow, there's a lot of options to this command!! If I were starting on implementing cargo install -p [crate to install from crates.io], I'd probably:

• Create a PackageRegistry (example of creating one)
• Get the central SourceId using SourceId::from_central
• Create a new PackageId from the name, version, and central SourceId
• Call registry.get(&[pkgid]) to download the source and get a Package
• Call ops::compile with the Package's manifest_path() and whatever options are appropriate for cargo install
• Copy/symlink/whatever the binaries resulting from that to the install location

I could also be totally wrong about this! Some other places to look:

• When cargo is reading a Cargo.toml, there's logic around creating a SourceId from git or from the central repo, but in order to reuse that, you'd have to create TOML from the arguments and that seems like going backwards, so maybe that logic could be extracted somewhere shared?
• Dependency also has some parse logic, but that feels weird because the thing you're cargo installing isn't a dependency of anything

Hope that helps!!!!

[alexcrichton]

This should actually be accessible through config.home().join("bin")

[alexcrichton]

@carols10cents is also right on the money :)

[ticki]

Why store the executables in $HOME rather than in /usr/local/bin? I prefer the latter.

[steveklabnik]

Please read the RFC for the answer to this.

On Sep 9, 2015, at 08:01, Ticki [email protected] wrote:

Why store the executables in $HOME rather than in /usr/local/bin? I prefer the latter.

―
Reply to this email directly or view it on GitHub.

[ticki]

Oh, sorry!

[cuzbog]

Bump!

[steveklabnik]

Yeah, I haven't had the chance to keep working on this. If someone else
wants to work on it, feel free, I will not be mad.

On Sun, Oct 4, 2015 at 11:17 AM, Bogdan Cuza [email protected]
wrote:

Bump!

—
Reply to this email directly or view it on GitHub
#1967 (comment).

[cuzbog]

I guess I could address the issues pointed out by @alexcrichton

[alexcrichton]

@boghison oh I'm actually going to be starting work on cargo install pretty soon (this coming week or so), so there should be movement on this quite soon!

[cuzbog]

@alexcrichton Oh, if you want to work on it, then I guess I shouldn't get in the way

[alexcrichton]

Continued in #2026, thanks @steveklabnik!