Skip to content

fix(cli): Remove --lockfile-path #16621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
epage wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): Remove --lockfile-path #16621

epage wants to merge 1 commit into from

Conversation

@epage
Copy link
Contributor

@epage epage commented Feb 10, 2026

What does this PR try to resolve?

Part of #14421

How to test and review this PR?

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

epage
epage commented Feb 10, 2026
View reviewed changes
src/bin/cargo/commands/add.rs
Copy link
Contributor Author

@epage epage Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-analyzer hasn't switched to resolver.lockfile-path yet

Copy link
Contributor Author

@epage epage Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @rust-lang/rust-analyzer

Copy link
Member

@ShoyuVanilla ShoyuVanilla Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. Yeah, looks like we should switch to it soonish 😅

@ShoyuVanilla ShoyuVanilla mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ShoyuVanilla ShoyuVanilla ShoyuVanilla left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@weihanglo weihanglo

Labels

A-cli Area: Command-line interface, option parsing, etc. Command-add Command-bench Command-build Command-check Command-clean Command-doc Command-fetch Command-fix Command-generate-lockfile Command-install Command-metadata Command-package Command-pkgid Command-publish Command-remove Command-run Command-rustc Command-rustdoc Command-test Command-tree Command-update Command-vendor S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@epage @rustbot @ShoyuVanilla @weihanglo