Skip to content

Let git decide when to run gc #16459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ojuschugh1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let git decide when to run gc #16459

ojuschugh1 wants to merge 1 commit into from
+12 −57

Conversation

@ojuschugh1
Copy link
Contributor

@ojuschugh1 ojuschugh1 commented Jan 2, 2026

What does this PR try to resolve?

Let git handle gc timing

Fixes #4495

We were counting packfiles ourselves, but git already does this
with gc --auto. No need to duplicate that logic.

@ojuschugh1
Use git gc --auto instead of custom logic
d9facc6 
Fixes rust-lang#4495

Let git decide when to run gc based on its own thresholds.

Signed-off-by: Ojus Chugh <[email protected]>
@rustbot rustbot added the A-git Area: anything dealing with git label Jan 2, 2026
@ojuschugh1 ojuschugh1 marked this pull request as ready for review January 2, 2026 20:10
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned epage and unassigned ehuss Jan 3, 2026
@epage epage changed the title Fixes issue #4495 Let git decide when to run gc Jan 5, 2026
epage
epage reviewed Jan 5, 2026
View reviewed changes
src/cargo/sources/git/utils.rs
Comment on lines -1370 to -1371
// Alright all else failed, let's start over.
reinitialize(repo)
Copy link
Contributor

@epage epage Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

@epage
Copy link
Contributor

epage commented Jan 5, 2026

This doesn't seem to be addressing the review feedback left in #4656 as called out at #4495 (comment).

@weihanglo
Copy link
Member

weihanglo commented Jan 31, 2026

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage epage left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@epage epage

Labels

A-git Area: anything dealing with git S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

let git decide when to run gc

5 participants

@ojuschugh1 @rustbot @epage @weihanglo @ehuss