fix(vendor)!: vendor files with .rej/.orig suffix #15569
Merged
+25
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
Command-vendor
S-waiting-on-review
|
Maybe I should do it in reversed order. |
So that it explicitly shows what we really vendor
This is meant to fixes rust-lang#13191 As git sources and registry sources are considered immutable. I don't think there is any reason excluding those files. There might be a little chance local Git repositories might have those, though that is a rare use case. Alternatively, we could reject all `.rej`/`.orig` files but `Cargo.toml.orig`.
Yeah, I'd put the snapshot first |
epage
reviewed
May 21, 2025
epage
reviewed
May 21, 2025
Comment on lines
618
to
619
| // Temporary Cargo files | ||
| Some(".cargo-ok") => false, |
There was a problem hiding this comment.
Now that we are doing fresh extractions, is this still needed?
There was a problem hiding this comment.
For git checkouts we still have that, though there is no test exercising that code path. Do you want a test for it in this PR?
There was a problem hiding this comment.
Let's go ahead and merge this
epage
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is meant to fixes #13191
As git sources and registry sources are considered immutable.
I don't think there is any reason excluding those files.
There might be a little chance local Git repositories might have those,
though that is a rare use case.
Alternatively,
we could reject all
.rej/.origfiles butCargo.toml.orig.How should we test and review this PR?
Test updates should be sufficient.
Additional information
This is a follow-up of #15514