Added tracing spans for rustc invocations #15464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-build-execution
weihanglo
reviewed
Apr 29, 2025
src/cargo/core/compiler/mod.rs
Outdated
| package = name.as_str(), | ||
| process = rustc.to_string() | ||
| ) | ||
| .entered(); | ||
|
|
||
| let result = exec |
There was a problem hiding this comment.
Alternatively, trace all execs?
There was a problem hiding this comment.
Sure, I think that also works.
I put it outside since Executor seems a bit generic, but looking at the function signatures it is very much designed to run rustc.
I went ahead and moved it inside of the Executor in addc570 since I think its a bit nicer to use the #[instrument] macro :)
ranger-ross
force-pushed
the
add-rustc-span
branch
from
26e3d69 to
addc570
Compare
arlosi
approved these changes
Apr 29, 2025
weihanglo
approved these changes
Apr 29, 2025
| @@ -140,10 +140,11 @@ pub trait Executor: Send + Sync + 'static { | |||
| pub struct DefaultExecutor; | |||
|
|
|||
| impl Executor for DefaultExecutor { | |||
| #[instrument(name = "rustc", skip_all, fields(package = id.name().as_str(), process = cmd.to_string()))] | |||
There was a problem hiding this comment.
Just note that this is at INFO log level.
Our instruments are all like this, but I feel like we might want to downgrade to debug or trace. Not a blocker though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
While doing some investigation on the theoretical performance implications of #4282 (and #15010 by extension) I was profiling cargo with some experimental changes. (Still a work in progress)
But in the mean time, noticed that we do not have spans for rustc invocations. I think these would be useful when profiling
cargo build. (cargo build --timingexists but is more geared towards debugging a slow building project, not cargo itself)For reference below is an example before/after of a profile run of a dummy crate with a few random dependencies.
Before
After