-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Uplift windows Cygwin DLL import libraries #15193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
I don't think the CI failure is related to this PR's changes... |
It looks like a regression in rustdoc in xcompile nightly feature (or a behavior change if that is intended). This
And probably this PR rust-lang/rust#138535. |
@Berrysoft could you rebase onto master so we can merge it? |
- needed to link std correctly Signed-off-by: Ookiineko <[email protected]>
Head branch was pushed to by a user without write access
Rebased. |
A CI fails, because of stack overflow? |
We had that in the past: #14312 (comment). No idea how. Let me re-run.
|
@weihanglo Do you happen to know what job that was? Was it msvc or gnu? |
Update cargo 10 commits in 307cbfda3119f06600e43cd38283f4a746fe1f8b..a6c604d1b8a2f2a8ff1f3ba6092f9fda42f4b7e9 2025-03-20 20:00:39 +0000 to 2025-03-26 18:11:00 +0000 - fix(package): update tracking issue for `--message-format` (rust-lang/cargo#15354) - docs(contrib): Expand the description of team meetings (rust-lang/cargo#15349) - feat(package): add unstable `--message-format` flag (rust-lang/cargo#15311) - feat(complete): Added completion for `--profile` (rust-lang/cargo#15308) - Uplift windows Cygwin DLL import libraries (rust-lang/cargo#15193) - do not pass cdylib link args to test (rust-lang/cargo#15317) - fix: revert the behavior checking lockfile's VCS status (rust-lang/cargo#15341) - Temporarily ignore cargo_test_doctest_xcompile_ignores (rust-lang/cargo#15348) - docs: fix typo in the "Shared cache" section (rust-lang/cargo#15346) - Fix some issues with future-incompat report generation (rust-lang/cargo#15345) r? ghost
Related: rust-lang/rust#134999