Skip to content

Check keywords length during publish --dry-run #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Check keywords length during publish --dry-run #13334

wants to merge 1 commit into from

Conversation

txtyash
Copy link

@txtyash txtyash commented Jan 22, 2024

This commit adds a length check on keywords in Cargo.toml. This will ensure that the user is aware of the limit on the length of keywords when running cargo publish --dry-run

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2024
@epage
Copy link
Contributor

epage commented Jan 22, 2024

Number of keywords is a crates.io-specific rule while cargo is meant to be able to work with registries in addition to crates.io which can have their own rules.

Additionally, crates.io can change their validation rules at any point and cargo can't match. I'm going to close this in saying that more discussion is needed on #4377. If there is a reason we should keep this PR open, let us know!

@epage epage closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interacts-with-crates.io Area: interaction with registries Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants