Don't compile on install without binaries#10842
Don't compile on install without binaries#10842yerke wants to merge 3 commits intorust-lang:masterfrom
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
|
@ehuss Do you mind taking a look when you have time? Specifically, I want some guidance on this proposal: Of course, I would love to hear from @epage and @weihanglo as well :) Thanks! |
|
I would prefer to not modify As mentioned in #9576 (comment), is it possible to adjust the checks to retain the error message? |
|
☔ The latest upstream changes (presumably #11410) made this pull request unmergeable. Please resolve the merge conflicts. |
|
For now I don't have any good ideas on how to achieve this without modifying |
Fixes #8970
This PR is trying to revive the effort started in #9576.
We don't want to compile code if there is no viable binary when running
cargo install my-name-here.The PR in the current form is not great. Due to the new compile filter, we show
warning: Target filter `bins` specified, but no targets matched. This is a no-op, even when the customer did not specify--bins.I think one the way to address this issue would to update
CompileMode::BuildtoCompileMode::Build { install: bool }, but I am not sure if that change would be welcome.