Skip to content

Commit 81955eb

Browse files
authored
chore: depend on openssl-sys to correctly pin its version (#15224)
### What does this PR try to resolve? From #13546 (comment) > This was an overlook in <#15166> and apparently we forgot to actually add openssl-sys to `cargo` package. The pinned version is [under `workspace.dependencies`](#15166) so it never really affect the dependency resolution. > > The bad news is that <#15166> is now in beta toolchain already. If we're going to fix this again we might need to revert it in beta as well. This PR fixes it. However, I think we should find a way to unpin the version. ### How should we test and review this PR? If we're going to merge this, we might want to backport to beta
2 parents 2decae7 + e0ad237 commit 81955eb

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Cargo.lock

+5-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ cargo-credential-macos-keychain.workspace = true
234234

235235
[target.'cfg(not(windows))'.dependencies]
236236
openssl = { workspace = true, optional = true }
237+
openssl-sys = { workspace = true, optional = true } # HACK: for pinning to openssl v1.
237238

238239
[target.'cfg(windows)'.dependencies]
239240
cargo-credential-wincred.workspace = true

0 commit comments

Comments
 (0)