Skip to content

Commit 2decae7

Browse files
authored
chore: dont check cargo-util semver until 1.86 is released (#15222)
### What does this PR try to resolve This fixes the current confusing failures in our CI pipeline: * https://github.com/rust-lang/cargo/actions/runs/13465687015/job/37630870984 * https://github.com/rust-lang/cargo/actions/runs/13469881475/job/37642079118?pr=15104 CI job failed because of this major SemVer breakage: ```diff -pub fn strip_prefix_canonical<P: AsRef<Path>>( - path: P, - base: P, +pub fn strip_prefix_canonical( + path: impl AsRef<Path>, + base: impl AsRef<Path>, ) -> Result<PathBuf, std::path::StripPrefixError> { ``` While cargo-util does have that change violating SemVer, it is unlikely people use it with turbo-fish syntax. And cargo-util is essentially for internal use. See: * https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/check-version-bump.20failure * https://forge.rust-lang.org/policies/crate-ownership.html#internal-use ### How should we test and review this PR? CI passes and we're all good, though we are violating SemVer policy 😬.
2 parents 1d1d646 + 80331b1 commit 2decae7

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

crates/xtask-bump-check/src/xtask.rs

+11
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,18 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
206206
let mut cmd = ProcessBuilder::new("cargo");
207207
cmd.arg("semver-checks")
208208
.arg("check-release")
209+
// Don't check cargo-util util 1.86 is released.
210+
// While it does have a SemVer breakage,
211+
// it is unlikely people use it with turbo-fish syntax.
212+
// And cargo-util is essentially for internal use.
213+
//
214+
// See:
215+
//
216+
// * https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/check-version-bump.20failure
217+
// * https://forge.rust-lang.org/policies/crate-ownership.html#internal-use
218+
.args(&["--exclude", "cargo-util"])
209219
.arg("--workspace");
220+
210221
gctx.shell().status("Running", &cmd)?;
211222
cmd.exec()?;
212223
if github {

0 commit comments

Comments
 (0)