Add to mergeable queue on PR push, open and reopen #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakib25800
commented
Apr 26, 2025
src/bors/handlers/pr_events.rs
Outdated
| db.set_pr_status( | ||
| let pr = &payload.pull_request; | ||
| let pr_number = pr.number; | ||
| db.get_or_create_pull_request( |
There was a problem hiding this comment.
This should really be named db.upsert_pull_request(...) rather than db.get_or_create_pull_request(...) because it updates the PR's base_branch, mergeable_state and status.
Will update it if you agree.
There was a problem hiding this comment.
Good point, a more accurate name is get_or_update, which is essentially just upsert.
Kobzol
reviewed
Apr 28, 2025
src/bors/handlers/pr_events.rs
Outdated
| .lock() | ||
| .get_pr_mut(default_pr_number()) | ||
| .mergeable_state = OctocrabMergeableState::Unknown; | ||
| tester |
There was a problem hiding this comment.
We know that a push always sets the unknown state, so we could add the logic of setting Unknown directly to push_to_pr, to make sure that we don't forget it, and so that we don't have to do it in every test that checks the mergeability status.
|
Needs a reformat :) |
Sakib25800
force-pushed
the
add-async-merge-checks
branch
from
0a17b58 to
3a4348b
Compare
Sakib25800
force-pushed
the
add-async-merge-checks
branch
from
3a4348b to
c0ce5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #218
This PR adds to the mergeable queue on: