feat: added check for invalid username and if it is invalid find related names #200
Conversation
…t have close proximity
| @@ -1,6 +1,7 @@ | |||
| use anyhow::Context; | |||
| use octocrab::models::{App, Repository}; | |||
| use octocrab::{Error, Octocrab}; | |||
| use strsim::levenshtein; | |||
There was a problem hiding this comment.
The strtim dependency is missing.
There was a problem hiding this comment.
oh shit, forgotten to push it, done now !
| async fn find_similar_usernames(&self, username: &str) -> anyhow::Result<Vec<String>> { | ||
| const MAX_DISTANCE: usize = 2; | ||
|
|
||
| let search_results = self |
There was a problem hiding this comment.
I wouldn't use the GitHub search API for this, that could be slow, and unknown GH users are not relevant anyway. Instead, we should try to search for known users in the team database. It will also be easier to test it like this.
But we can also skip the "find similar" functionality in this PR, if you want.
There was a problem hiding this comment.
I wouldn't use the GitHub search API for this, that could be slow, and unknown GH users are not relevant anyway. Instead, we should try to search for known users in the team database. It will also be easier to test it like this.
so we should use this right ?
Line 51 in 417c8e7
There was a problem hiding this comment.
Yes, the reviewer list from the team API.
Fixes #191