Document the loop_break_value feature #699
Conversation
|
Thanks! Looks like this is going to need the |
|
Is the |
|
It's making the build fail, I'm fine letting this PR sit until it stabilizes if that's ok with you, but I'm not going to merge it with failing tests. |
|
Sure. Let's wait a bit for this. |
|
Isn't this a duplicate of #41857? Or are there two completely separate books? |
|
AFAIK the unstable book is different than the "standard" book. By the way, I didn't notice your pull request when I wrote this because you didn't link it to the tracking issue (and apparently you didn't link properly your pull request in the reference either) :). I think for the "newest features" appendix a brief description (like in this PR) to let the reader know this feature exists and how to use it is better than a more in-depth explaination like in your PR, though. |
|
Yes, I seem to have forgotten a few links, sorry about that. Unfortunately your stabilisation PR and my unstable book PR conflict, so maybe I need to move my additions @carols10cents ? This PR looks fine to me BTW. |
I don't understand what you mean by "conflict", they're in totally different repos? |
|
I think he means his PR to add the docs in the unstable book conflicts with my PR to stabilize the feature (which removes the page in the unstable book). |
|
Hey @dhardy, @pietroalbini So, the idea is this: the Unstable Book is for WIP docs while a feature is unstable. Once the feature becomes stable, it gets removed from the Unstable Book, and then moved here. However, that process makes some assumptions, that is, not that the docs in the unstable book are added right before something is made stable 😄 I didn't realize that this feature was so close to being stable, given that life has been busy lately, so they're not so much in conflict as rust-lang/rust#41857 will be very short-lived. Here's my plan: I'm going to merge that PR, since @dhardy should get some credit for his work, and this confusion is mine. Then, if @pietroalbini rebases their PR, it will remove those docs, and everything is fine. |
|
Thanks @steveklabnik but it still wastes my docs. Oh well, if they're not useful, so be it. |
|
The stabilization PR was merged \o/ Should we merge this now? |
|
Let me restart Travis. |
|
Looks like it missed the nightly so we'll have to wait until tomorrow. |
|
Hmm, travis is still using an old nightly of rust for some reason. Maybe rebase this, @pietroalbini ? |
|
What. Travis is still using |
|
Oops. We pinned nightly because there was a day that rustup wasn't able to install nightly, and that was supposed to be temporary, but I forgot to put it back to just |
This commit adds a section to the newest features appendix about the loop_break_value feature, which should be stabilized soon.
This pull requests adds a section in the new features appendix about the
loop_break_valuefeature (which should be stabilized after all the documentation is ready), tracked in issue rust-lang/rust#37339.I reused the basic example I made for Rust by Example, but if something more realistic (maybe with threads and channels) is OK here I'm happy to change it.