Skip to content

fix: minor typo in chapter 17 documentation #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nostarch/chapter17.md
Original file line number Diff line number Diff line change
Expand Up @@ -2715,7 +2715,7 @@ function. The signature for `join_all` requires that the types of the items in
the collection all implement the `Future` trait, and `Box<T>` implements
`Future` only if the `T` it wraps is a future that implements the `Unpin` trait.

That’s a lot to absorb! To really understand it, let’s we dive a little further
That’s a lot to absorb! To really understand it, let’s dive a little further
into how the `Future` trait actually works, in particular around *pinning*.

Look again at the definition of the `Future` trait:
Expand All @@ -2737,7 +2737,7 @@ knows when to check any given future while still being lazy. Again, the details
of how that works are beyond the scope of this chapter, and you generally only
need to think about this when writing a custom `Future` implementation. We’ll
focus instead on the type for `self`, as this is the first time we’ve seen a
method where `self` has a type annotation. A type annotation for `self` is works
method where `self` has a type annotation. A type annotation for `self` works
like type annotations for other function parameters, but with two key
differences:

Expand Down