Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

I have not had a chance to fill in the stabilized APIs and some feedback from the Zulip thread is still unaddressed; it would be great for concrete suggestions on how to improve things. General review is of course appreciated as well.

r? @pietroalbini

cc @rust-lang/release

@Mark-Simulacrum Mark-Simulacrum requested a review from a team July 22, 2021 19:22
@calebcartwright
Copy link
Member

Realize rustfmt info isn't typically included in the release notes, but would it be worth including a footnote (not sure where) for rust-lang/rust#86424?

Maybe something like:

There was a bug in rustfmt on 1.53 where rustfmt wasn't seeing certain files and was unable to format them. That rustfmt bug has been fixed so users may see formatting diffs on 1.54 since rustfmt will be seeing some files for the first time since 1.52

@pietroalbini pietroalbini merged commit 3612e0c into rust-lang:master Jul 29, 2021
@pietroalbini pietroalbini deleted the 1.54 branch July 29, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants