Various cleanups #673
Merged
Various cleanups #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Sep 18, 2024
| match Error::last_os_error().raw_os_error() { | ||
| Some(libc::ENOMEM) => { | ||
| match errno() { | ||
| libc::ENOMEM => { |
There was a problem hiding this comment.
Not really sure if I should keep this change. If you want I will drop this commit.
|
Just noticed that #666 also did most of the changes in this PR. Will rebase once that PR os merged. |
|
@bjorn3 rebase please? |
Also avoids two unnecessary allocations in handle_split_dwarf.
|
Code size changes for a hello-world Rust program linked with libstd with backtrace: On platform
|
workingjubilee
force-pushed
the
mystd_refactor
branch
from
fab120c to
62c5764
Compare
|
Code size changes for a hello-world Rust program linked with libstd with backtrace: On platform
|
workingjubilee
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_split_dwarf.