fix: Match rustc's annotation overlap #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
rustc
, I saw thatannotate-snippets
andrustc
had different outputs forunsafe_extern_suggestion
. I spent some time digging into this, and it turns out we did not match howrustc
handled overlaps. Some of the ways I attempted to fix this divergence causedalloc_error_handler_bad_signature_2
andstr_escape
to regress, so I figured I would add them to help catch any future changes.