Skip to content

fix: Match rustc's annotation overlap #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Jul 8, 2025

While working on rustc, I saw that annotate-snippets and rustc had different outputs for unsafe_extern_suggestion. I spent some time digging into this, and it turns out we did not match how rustc handled overlaps. Some of the ways I attempted to fix this divergence caused alloc_error_handler_bad_signature_2 and str_escape to regress, so I figured I would add them to help catch any future changes.

@Muscraft Muscraft force-pushed the annotation-overlap branch from a6be8a3 to 9e25598 Compare July 8, 2025 20:29
@Muscraft Muscraft merged commit 20b2070 into rust-lang:master Jul 8, 2025
15 checks passed
@Muscraft Muscraft deleted the annotation-overlap branch July 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants