Skip to content

remove deny lints #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023
Merged

remove deny lints #766

merged 3 commits into from
Nov 20, 2023

Conversation

burrbull
Copy link
Member

closes #763

@burrbull burrbull requested a review from a team as a code owner November 20, 2023 04:55
@burrbull
Copy link
Member Author

cc @Emilgardis what this error could mean?

ci/script.sh: line 66: RUST_TOOLCHAIN: unbound variable

@thejpster
Copy link
Contributor

I think it means that bash variable didn't have a value. It's on the line where you check if it's a nightly Rust version. But you also set the variable in CI before you call the script, so I'm confused?

@Emilgardis
Copy link
Member

the error is due to set -u, an easy fix is to use "${RUST_TOOLCHAIN:-}"

@Emilgardis Emilgardis added this pull request to the merge queue Nov 20, 2023
Merged via the queue into master with commit a5bd928 Nov 20, 2023
@Emilgardis Emilgardis deleted the rm-deny branch November 20, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look over usage of #[deny(...)]
3 participants