Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using associated functions, this PR proposes using methods. The benefits of this change are:
svd2rust
. Thus, the PACs using this tool will benefit from a more uniform API.Deref
trait to simplify theperipheral_codegen!
macros.I also removed the
embedded-hal-async
partial support. The reason for removing this is that while implementing a few asynchronous functions, I noticed that it is difficult to provide a generic and optimized implementation for any RISC-V target. Instead, I think it is more reasonable to implement a customchip-hal-async
crate that makes the most of the characteristics of a given chip.This is still a work-in-progress PR. I want to make sure that everything works as expected by updating
svd2rust
ande310x
.